[Linux-kernel-mentees] [PATCH net] tipc: Fix memory leak in tipc_group_create_member()

Peilin Ye yepeilin.cs at gmail.com
Sun Sep 13 07:49:23 UTC 2020


On Sat, Sep 12, 2020 at 06:23:36PM -0700, David Miller wrote:
> From: Peilin Ye <yepeilin.cs at gmail.com>
> Date: Sat, 12 Sep 2020 06:22:30 -0400
> 
> > @@ -291,10 +291,11 @@ static void tipc_group_add_to_tree(struct tipc_group *grp,
> >  		else if (key > nkey)
> >  			n = &(*n)->rb_right;
> >  		else
> > -			return;
> > +			return -1;
> 
> Use a real error code like "-EEXIST", thank you.

Ah, I'll fix it in v2 soon, sorry about that. I saw another function in
this file returning -1.

Peilin Ye


More information about the Linux-kernel-mentees mailing list