[Linux-kernel-mentees] [PATCH] checkpatch: fix author Signed-off-by warning for split From: header
Dwaipayan Ray
dwaipayanray1 at gmail.com
Fri Sep 18 12:29:50 UTC 2020
Checkpatch did not handle cases where the author From: header was
split into two lines. In those cases the author string went empty,
and checkpatch generated a false missing author signed-off-by
warning.
This patch adds support for split From: headers and resolves those
false warnings.
Signed-off-by: Dwaipayan Ray <dwaipayanray1 at gmail.com>
---
scripts/checkpatch.pl | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 504d2e431c60..8c4119ca7d17 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2347,6 +2347,7 @@ sub process {
my $signoff = 0;
my $author = '';
my $authorsignoff = 0;
+ my $prevheader = 0;
my $is_patch = 0;
my $is_binding_patch = -1;
my $in_header_lines = $file ? 0 : 1;
@@ -2658,12 +2659,22 @@ sub process {
}
}
+# Check the patch for a split From:
+ if ($author eq '' && decode("MIME-Header", $prevheader) =~ /^From:\s*(.*)/) {
+ $author = $1.$line;
+ $author = encode("utf8", $author) if ($prevheader =~ /=\?utf-8\?/i);
+ $author =~ s/"//g;
+ $author = reformat_email($author);
+ $prevheader = '';
+ }
+
# Check the patch for a From:
if (decode("MIME-Header", $line) =~ /^From:\s*(.*)/) {
$author = $1;
$author = encode("utf8", $author) if ($line =~ /=\?utf-8\?/i);
$author =~ s/"//g;
$author = reformat_email($author);
+ $prevheader = $line;
}
# Check the patch for a signoff:
--
2.27.0
More information about the Linux-kernel-mentees
mailing list