[Linux-kernel-mentees] checkpatch.pl investigation: NO_AUTHOR_SIGN_OFF issues
dwaipayanray1 at gmail.com
Wed Sep 23 07:38:40 UTC 2020
> > Hi,
> > As for the lk_path, it can be removed easily. To me too, it didn't make much
> > sense since it was just a duplicate, as $root should contain the same.
> > But again due to some reason,
> > $root in checkpatch had the value ".",
> > while $lk_path in get_maintainer had the value "./"
> > I have no idea yet if this was a design decision or just different handling.
> > So, I can change the part where I referenced the mailmap file by adding
> > a trailing / with $root rather than $lk_path. That should do it.
> > And for the duplicate code part, Joe did mention that either I could copy
> > or place the read_mailmap code in a separate file and reference both
> > checkpatch and get_maintainers from there.
> > To me, copying seems much feasible because the referenced part of the
> > mailmap handling code here is very small as there are some minor
> > changes.
> Well, if you can argue copying code, it is fine. Go ahead and send out a
> RFC patch.
I definitely know that redundant code is a bad practice. But yes, I would
send a patch in with a proper commit message to get yours and Joe's
> Regarding the mentorship, would you have time for some virtual
> face-to-face meeting to discuss the Eligibility Criteria and Mentorship
Yes sure, what time are you available? I don't have any more classes
today so I am free.
More information about the Linux-kernel-mentees