[Linux-kernel-mentees] [PATCH RFC] checkpatch: extend same_email_address check to load mailmap entries

Joe Perches joe at perches.com
Wed Sep 23 10:17:56 UTC 2020


On Wed, 2020-09-23 at 15:32 +0530, Dwaipayan Ray wrote:
> Checkpatch throws a NO_AUTHOR_SIGN_OFF warning whenever either the
> name or email address of author doesn't match any signed-off-by
> entry. But it has no mechanism to check whether different email
> addresses belong to the same author.
> 
> As a result, there have been multiple commits where the author has
> signed off with a different email address which caused checkpatch
> to product that warning.
> 
> An example is commit dc5bdb68b5b3 ("drm/fb-helper: Fix vt restore"),
> where the author uses two different mail addresses, and checkpatch
> generates a NO_AUTHOR_SIGN_OFF warning.

.mailmap entries are used when a person no longer has
access to a particular email and a mapping is created to
allow these old/invalid email addresses to be converted
to a current/valid email address.

The idea here is that a person may have a .gitconfig or
equivalent that still uses an old/invalid email address
but uses a Signed-off-by: for a current/valid one, so
a warning _should_ be emitted for this case.

At least for checkpatch, mismatches in email addresses
should not be papered over by assuming equivalence between
multiple email addresses.

So this should be a separate test and not used in a function
named
"same_email_address".  These are specifically _not_
the same email
addresses.




More information about the Linux-kernel-mentees mailing list