[PATCH] USB: serial: iuu_phoenix: Replace symbolic permissions by octal permissions

Lukas Bulwahn lukas.bulwahn at gmail.com
Tue Aug 3 18:11:28 UTC 2021


On Tue, Aug 3, 2021 at 4:21 PM Utkarsh Verma <utkarshverma294 at gmail.com> wrote:
>
> This fixed the below checkpatch issue:

Use imperative; you can drop "below" here.

> WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
> Consider using octal permissions '0644'.
>
> Signed-off-by: Utkarsh Verma <utkarshverma294 at gmail.com>
> Suggested-by: Lukas Bulwahn <lukas.bulwahn at gmail.com>

Usually it is Suggested-by first, then Signed-off-by at the end.

Do you find a pointer for this order of tags on the commit message in
the documentation, e.g., in
Documentation/process/submitting-patches.rst?


Lukas


More information about the Linux-kernel-mentees mailing list