[RESEND PATCH v5 4/6] Bluetooth: serialize calls to sco_sock_{set, clear}_timer

Desmond Cheong Zhi Xi desmondcheongzx at gmail.com
Wed Aug 4 15:47:10 UTC 2021

Currently, calls to sco_sock_set_timer are made under the locked
socket, but this does not apply to all calls to sco_sock_clear_timer.

Both sco_sock_{set,clear}_timer should be serialized by lock_sock to
prevent unexpected concurrent clearing/setting of timers.

Additionally, since sco_pi(sk)->conn is only cleared under the locked
socket, this change allows us to avoid races between
sco_sock_clear_timer and the call to kfree(conn) in sco_conn_del.

Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx at gmail.com>
 net/bluetooth/sco.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c
index 1246e6bc09fe..418543c390b3 100644
--- a/net/bluetooth/sco.c
+++ b/net/bluetooth/sco.c
@@ -459,8 +459,8 @@ static void __sco_sock_close(struct sock *sk)
 /* Must be called on unlocked socket. */
 static void sco_sock_close(struct sock *sk)
-	sco_sock_clear_timer(sk);
+	sco_sock_clear_timer(sk);
@@ -1110,8 +1110,8 @@ static void sco_conn_ready(struct sco_conn *conn)
 	BT_DBG("conn %p", conn);
 	if (sk) {
-		sco_sock_clear_timer(sk);
+		sco_sock_clear_timer(sk);
 		sk->sk_state = BT_CONNECTED;

More information about the Linux-kernel-mentees mailing list