[PATCH v3] Documentation: checkpatch: Add SYMBOLIC_PERMS message
dwaipayanray1 at gmail.com
Thu Aug 5 13:51:50 UTC 2021
On Wed, Aug 4, 2021 at 9:02 PM Utkarsh Verma <utkarshverma294 at gmail.com> wrote:
> Add a new message type SYMBOLIC_PERMS under the 'Permissions'
> subsection. Checkpatch documentation that recommends the user to use
Did you mean: Checkpatch recommends the user to use octal
Other than that the change itself looks fine to me.
> the octal permission bits instead of their symbolic macro names.
> Suggested-by: Lukas Bulwahn <lukas.bulwahn at gmail.com>
> Signed-off-by: Utkarsh Verma <utkarshverma294 at gmail.com>
> Documentation/dev-tools/checkpatch.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
> diff --git a/Documentation/dev-tools/checkpatch.rst b/Documentation/dev-tools/checkpatch.rst
> index f0956e9ea..009957cda 100644
> --- a/Documentation/dev-tools/checkpatch.rst
> +++ b/Documentation/dev-tools/checkpatch.rst
> @@ -957,6 +957,12 @@ Permissions
> Permission bits should use 4 digit octal permissions (like 0700 or 0444).
> Avoid using any other base like decimal.
> + **SYMBOLIC_PERMS**
> + Permission bits in the octal form are more readable and easier to
> + understand than their symbolic counterparts.
> + See: https://lore.kernel.org/lkml/CA+55aFw5v23T-zvDZp-MmD_EYxF8WbafwwB59934FV7g21uMGQ@mail.gmail.com/
> Spacing and Brackets
More information about the Linux-kernel-mentees