[PATCH v2] Task2: checkpatch.pl documentation mentorship: Remove semicolon warnings

Lukas Bulwahn lukas.bulwahn at gmail.com
Tue Aug 10 11:59:30 UTC 2021


On Mon, Aug 9, 2021 at 11:17 PM Rahul Balaji <rahulbalaji78 at gmail.com> wrote:
>
>
>
> On Tue, 3 Aug 2021, 6:11 pm Rahul Balaji, <rahulbalaji78 at gmail.com> wrote:
>>
>> Signed-off-by: Rahul Balaji <rahulbalaji78 at gmail.com>
>>
>> no functional changes.
>>
>>  drivers/gpu/drm/nouveau/nouveau_gem.c | 2 +-
>>  drivers/mtd/ubi/block.c               | 2 +-
>>  fs/block_dev.c                        | 2 +-
>>  include/trace/events/iocost.h         | 2 +-
>>  4 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c
>> index 5b27845075a1..d476940ee97c 100644
>> --- a/drivers/gpu/drm/nouveau/nouveau_gem.c
>> +++ b/drivers/gpu/drm/nouveau/nouveau_gem.c
>> @@ -339,7 +339,7 @@ nouveau_gem_set_domain(struct drm_gem_object *gem, uint32_t read_domains,
>>         struct ttm_buffer_object *bo = &nvbo->bo;
>>         uint32_t domains = valid_domains & nvbo->valid_domains &
>>                 (write_domains ? write_domains : read_domains);
>> -       uint32_t pref_domains = 0;;
>> +       uint32_t pref_domains = 0;
>>
>>         if (!domains)
>>                 return -EINVAL;
>> diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c
>> index e003b4b44ffa..e0402c2f8959 100644
>> --- a/drivers/mtd/ubi/block.c
>> +++ b/drivers/mtd/ubi/block.c
>> @@ -405,7 +405,7 @@ int ubiblock_create(struct ubi_volume_info *vi)
>>         ret = blk_mq_alloc_tag_set(&dev->tag_set);
>>         if (ret) {
>>                 dev_err(disk_to_dev(dev->gd), "blk_mq_alloc_tag_set failed");
>> -               goto out_free_dev;;
>> +               goto out_free_dev;
>>         }
>>
>>
>> diff --git a/fs/block_dev.c b/fs/block_dev.c
>> index 9ef4f1fc2cb0..61b938fa5d5b 100644
>> --- a/fs/block_dev.c
>> +++ b/fs/block_dev.c
>> @@ -1268,7 +1268,7 @@ static int blkdev_get_whole(struct block_device *bdev, fmode_t mode)
>>         if (test_bit(GD_NEED_PART_SCAN, &disk->state))
>>                 bdev_disk_changed(disk, false);
>>         bdev->bd_openers++;
>> -       return 0;;
>> +       return 0;
>>  }
>>
>>  static void blkdev_put_whole(struct block_device *bdev, fmode_t mode)
>> diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
>> index e282ce02fa2d..6d1626e7a4ce 100644
>> --- a/include/trace/events/iocost.h
>> +++ b/include/trace/events/iocost.h
>> @@ -160,7 +160,7 @@ TRACE_EVENT(iocost_ioc_vrate_adj,
>>
>>         TP_fast_assign(
>>                 __assign_str(devname, ioc_name(ioc));
>> -               __entry->old_vrate = atomic64_read(&ioc->vtime_rate);;
>> +               __entry->old_vrate = atomic64_read(&ioc->vtime_rate);
>>                 __entry->new_vrate = new_vrate;
>>                 __entry->busy_level = ioc->busy_level;
>>                 __entry->read_missed_ppm = missed_ppm[READ];
>> --
>> 2.25.1
>
>
>
> Respected mentors,
>
> Please do find the changes in the same mail quoted as above.
>

Rahul, this is not the way to submit a patch to the kernel mailing list.

First, I do not see the "quote" in this email, I assume you mean the
email before in this email thread?

Second, the commit message in the patch needs to contain all
information relevant for exactly that one change you are proposing,
and should not just refer to other emails.

(And if you refer to emails, use links to lore.kernel.org and use the
Link: tag. Careful, that is already advanced knowledge for patch
submission; get the basics right first.)

I suggest you try with another PATCH v3 and then we see what we got here.

Lukas


More information about the Linux-kernel-mentees mailing list