[Linux-kernel-mentees] [PATCH] checkpatch: trivial style fixes

Dwaipayan Ray dwaipayanray1 at gmail.com
Tue Jan 5 08:41:04 UTC 2021


On Tue, Jan 5, 2021 at 1:34 PM Lukas Bulwahn <lukas.bulwahn at gmail.com> wrote:
>
> On Mon, Jan 4, 2021 at 2:25 PM Dwaipayan Ray <dwaipayanray1 at gmail.com> wrote:
> >
> > Indentations should use tabs wherever possible.
> > Replace spaces by tabs for indents.
> >
> > Signed-off-by: Dwaipayan Ray <dwaipayanray1 at gmail.com>
>
> Looks good.
>
> Find out who is to blame for this stylistic mess up. (use git blame).
>
> If it is Aditya, let him know to check better and how you discovered
> this mess-up.
>

I think some of Aditya's earlier patches caused this. I was idly running the
regex "^[ ]+" on files which detected these misuses. Probably it's a
broken editor
which expanded tabs, maybe vim with exandtab set. Aditya could you verify your
editor config? Thanks.

Thank you,
Dwaipayan.

>
> Lukas
>
> > ---
> >  scripts/checkpatch.pl | 18 +++++++++---------
> >  1 file changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index b212f5f12ca6..d6a4d25b0972 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -2973,7 +2973,7 @@ sub process {
> >                                 }
> >                                 if (!defined $lines[$linenr]) {
> >                                         WARN("BAD_SIGN_OFF",
> > -                                             "Co-developed-by: must be immediately followed by Signed-off-by:\n" . "$here\n" . $rawline);
> > +                                            "Co-developed-by: must be immediately followed by Signed-off-by:\n" . "$here\n" . $rawline);
> >                                 } elsif ($rawlines[$linenr] !~ /^\s*signed-off-by:\s*(.*)/i) {
> >                                         WARN("BAD_SIGN_OFF",
> >                                              "Co-developed-by: must be immediately followed by Signed-off-by:\n" . "$here\n" . $rawline . "\n" .$rawlines[$linenr]);
> > @@ -2996,8 +2996,8 @@ sub process {
> >                         if (ERROR("GERRIT_CHANGE_ID",
> >                                   "Remove Gerrit Change-Id's before submitting upstream\n" . $herecurr) &&
> >                             $fix) {
> > -                                fix_delete_line($fixlinenr, $rawline);
> > -                        }
> > +                               fix_delete_line($fixlinenr, $rawline);
> > +                       }
> >                 }
> >
> >  # Check if the commit log is in a possible stack dump
> > @@ -3239,10 +3239,10 @@ sub process {
> >                                 next if ($start_char =~ /^\S$/);
> >                                 next if (index(" \t.,;?!", $end_char) == -1);
> >
> > -                                # avoid repeating hex occurrences like 'ff ff fe 09 ...'
> > -                                if ($first =~ /\b[0-9a-f]{2,}\b/i) {
> > -                                        next if (!exists($allow_repeated_words{lc($first)}));
> > -                                }
> > +                               # avoid repeating hex occurrences like 'ff ff fe 09 ...'
> > +                               if ($first =~ /\b[0-9a-f]{2,}\b/i) {
> > +                                       next if (!exists($allow_repeated_words{lc($first)}));
> > +                               }
> >
> >                                 if (WARN("REPEATED_WORD",
> >                                          "Possible repeated word: '$first'\n" . $herecurr) &&
> > @@ -4426,7 +4426,7 @@ sub process {
> >                         WARN("STATIC_CONST_CHAR_ARRAY",
> >                              "char * array declaration might be better as static const\n" .
> >                                 $herecurr);
> > -               }
> > +               }
> >
> >  # check for sizeof(foo)/sizeof(foo[0]) that could be ARRAY_SIZE(foo)
> >                 if ($line =~ m@\bsizeof\s*\(\s*($Lval)\s*\)@) {
> > @@ -5279,7 +5279,7 @@ sub process {
> >                     $lines[$linenr - 3] !~ /^[ +]\s*$Ident\s*:/) {
> >                         WARN("RETURN_VOID",
> >                              "void function return statements are not generally useful\n" . $hereprev);
> > -               }
> > +               }
> >
> >  # if statements using unnecessary parentheses - ie: if ((foo == bar))
> >                 if ($perl_version_ok &&
> > --
> > 2.27.0
> >


More information about the Linux-kernel-mentees mailing list