[Linux-kernel-mentees] comment on checkpatch

Lukas Bulwahn lukas.bulwahn at gmail.com
Tue Jan 12 06:03:21 UTC 2021


On Tue, Jan 12, 2021 at 6:35 AM Dwaipayan Ray <dwaipayanray1 at gmail.com> wrote:
>
> On Tue, Jan 12, 2021 at 10:38 AM Lukas Bulwahn <lukas.bulwahn at gmail.com> wrote:
> >
> > https://lore.kernel.org/linux-next/20210111230029.GM4728@sirena.org.uk/T/#m355576186555c4b6e85dbb9a1b3fe3d5e80f6e9f
> >
> > Aditya, Dwaipayan, Have a look. checkpatch already handles this, right?
> >
> Hi
> The following Fixes line in commit log emits no warning:
>    Fixes: Use packed mode for 32 bits per word transfers to increase
>
> Neither does a fixes with mismatched commit description:
>    Fixes: e4da63cda51f ("networking: packet_mmap: fix old config reference")
>
> which should have been infact:
>    Fixes: e4da63cda51f ("docs: networking: packet_mmap: fix old config
> reference")
>
> I could work on this if Lukas and Joe are okay with it.
>

Sounds good to me. Although I always thought checkpatch already has
such a check... we do check commit sha ("description"); so checking
Fixes can reuse that checking.

Lukas


More information about the Linux-kernel-mentees mailing list