[PATCH v7 1/2] firmware_loader: use -ETIMEDOUT instead of -EAGAIN in fw_load_sysfs_fallback

Luis Chamberlain mcgrof at kernel.org
Mon Jul 26 18:07:44 UTC 2021


On Sat, Jul 24, 2021 at 05:41:33PM +0530, Anirudh Rayabharam wrote:
> The only motivation for using -EAGAIN in commit 0542ad88fbdd81bb
> ("firmware loader: Fix _request_firmware_load() return val for fw load
> abort") was to distinguish the error from -ENOMEM, and so there is no
> real reason in keeping it. -EAGAIN is typically used to tell the
> userspace to try something again and in this case re-using the sysfs
> loading interface cannot be retried when a timeout happens, so the
> return value is also bogus.
> 
> -ETIMEDOUT is received when the wait times out and returning that
> is much more telling of what the reason for the failure was. So, just
> propagate that instead of returning -EAGAIN.
> 
> Suggested-by: Luis Chamberlain <mcgrof at kernel.org>
> Signed-off-by: Anirudh Rayabharam <mail at anirudhrb.com>

Acked-by: Luis Chamberlain <mcgrof at kernel.org>

Beautiful.

As you see, without any of this documented in a commit log, the change
would have been very obscure. Now we cleary document a userspace
changing return value clearly.

Thanks!

  Luis


More information about the Linux-kernel-mentees mailing list