patch suggestion: Kconfig symbols
rdunlap at infradead.org
Tue Jul 27 00:21:02 UTC 2021
Running scripts/checkkconfigsymbols.py reports several hundred (maybe thousand)
Kconfig symbols that are used questionably. Lots of these are false positives
but lots of the remainder could use some cleaning up.
Referencing files: arch/mips/configs/gpr_defconfig, arch/mips/configs/mtx1_defconfig, drivers/net/wan/Kconfig
Similar symbols: SCC, DMASCC, CRC4, CRC64
There is no longer a Kconfig entry for DSCC4 (it has been deleted, but some
references to it were not deleted) -- and this is not a typo
of one of the "Similar symbols" listed here.
So all of these references to DSCC4 can be (should be) deleted.
And of course, Cc: the GENERIC HDLC (WAN) DRIVERS maintainer on such a patch.
False positive example:
Referencing files: drivers/scsi/qla2xxx/qla_mbx.c
Similar symbols: OF_PMEM, CXL_MEM, CXL_PMEM
The Referencing source file does this:
#define CONFIG_XCHOFFLD_MEM 0x3
which is legitimate, so no change is needed.
Referencing files: arch/x86/include/asm/ia32.h
Similar symbols: MEDIA_SUPPORT, EDAC_SUPPORT, IOMMU_SUPPORT, USB_SUPPORT, I2C_PARPORT, NIOS2_FPU_SUPPORT, NIOS2_CDX_SUPPORT, NIOS2_BMX_SUPPORT, MEDIA_USB_SUPPORT, MEDIA_SDR_SUPPORT
The Referencing file has:
#endif /* !CONFIG_IA32_SUPPORT */
and this #ifdef block was begun with
so the comment on the #endif line is incorrect.
This could be fixed but it's not a big deal just to leave it as is.
So there is lots here that could be done, but there are also lots of
false positives here that don't need to be touched.
More information about the Linux-kernel-mentees