Checkpatch still worries about include/asm/ ?

Dwaipayan Ray dwaipayanray1 at gmail.com
Thu Mar 18 17:18:36 UTC 2021


On Thu, Mar 18, 2021 at 10:33 PM Lukas Bulwahn <lukas.bulwahn at gmail.com> wrote:
>
> On Thu, Mar 18, 2021 at 5:47 PM Dwaipayan Ray <dwaipayanray1 at gmail.com> wrote:
> >
> > Hello,
> > include/asm/ got removed a long time back (probably v1.1.45).
> > Checkpatch still worries about that:
> >
> > if ($realfile =~ m@^include/asm/@) {
> > ERROR("MODIFIED_INCLUDE_ASM",
> > "do not modify files in include/asm, change architecture specific
> > files in include/asm-<architecture>\n" . "$here$rawline\n");
> > }
> >
> > Can we remove this check?
> >
>
> Wow, v1.1.45... that must have been taking quite some digging in the
> ancient dirt to find that out.
>
I was actually helped by an user who send a patch in 2016 to remove it:
https://lore.kernel.org/lkml/1482260987-21457-1-git-send-email-pebolle@tiscali.nl/raw

Don't know why it wasnt removed back then.
But it's safe to say this check hasn't been used for decades :)

> I agree, let us remove that rule.

Sure will send the patch.

> Thanks for the documentation effort on checkpatch.pl and cleaning up
> obsolete rules while documenting.
>
It's my pleasure!

Thanks & Regards,
Dwaipayan.


More information about the Linux-kernel-mentees mailing list