[PATCH v2 1/2] staging: rtl8192e: Fix incorrect source in memcpy()
atulgopinathan at gmail.com
Tue Mar 23 17:29:07 UTC 2021
On Tue, Mar 23, 2021 at 04:58:11PM +0300, Dan Carpenter wrote:
> Reviewed-by: Dan Carpenter <dan.carpenter at oracle.com>
> This is very clever detective work. How did you spot the bug?
I remember trying to investigate a sparse warning couple of weeks ago in
the same file and went through the code when my eyes caught a struct
pointer being indexed, which looked wierd. On further reading of the
code and trying to make sense of what was happening (especially after
calculating the size of the pointer) I became sure that it wasn't
The first patch led me to the second patch as they were related,
"CcxRmState" was used in the same memcpy() of the first patch. I caught
the error in it's type while trying to fix the first.
Thank you for your encouraging words :D
More information about the Linux-kernel-mentees