[llvmlinux] [PATCH] toolchain: Fix llvm-sync target in clang.mk

Sedat Dilek sedat.dilek at gmail.com
Sat Jul 13 18:14:24 UTC 2013


'make llvm-sync' worked here not as expected when run like this:

   $ cd targets/x86_64/

   $ LC_ALL=C make CONFIG=checkpoints/config.mk llvm-sync

Each time the clang sources were downloaded.

Let's check the source-code:

[ toolchain/clang/clang.mk ]

 272 llvm-reset: ${LLVMSTATE}/clang-fetch
 295 llvm-clean: llvm-reset llvm-clean-noreset clang-clean

 307 clang-reset: ${LLVMSTATE}/clang-fetch
 326 clang-clean: clang-reset clang-clean-noreset

llvm-clean target invokes llvm-reset target which does a "clang-fetch"
whereas it should do a "llvm-fetch".

Fixing the llvm-reset target results in the expected download of llvm
sources.

I have noticed this while playing with the checkpoint feature and
have already reported the issue to the llvmlinux ML.

Signed-off-by: Sedat Dilek <sedat.dilek at gmail.com>
---
 toolchain/clang/clang.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/toolchain/clang/clang.mk b/toolchain/clang/clang.mk
index 64a2c15..6cf42f1 100644
--- a/toolchain/clang/clang.mk
+++ b/toolchain/clang/clang.mk
@@ -269,7 +269,7 @@ ${LLVMSTATE}/clang-unpatched-build: ${LLVMSTATE}/llvm-unpatched-build ${LLVMSTAT
 	$(call state,$@)
 
 ##############################################################################
-llvm-reset: ${LLVMSTATE}/clang-fetch
+llvm-reset: ${LLVMSTATE}/llvm-fetch
 #${LLVMSTATE}/compilerrt-fetch
 # Patched LLVM
 	@$(call banner,Cleaning LLVM...)
-- 
1.8.3.2



More information about the LLVMLinux mailing list