[llvmlinux] make llvm-sync: Typo in llvm-reset target/phony?

Behan Webster behanw at converseincode.com
Sat Jul 13 19:00:05 UTC 2013


On 07/13/13 14:17, Sedat Dilek wrote:
> OK, you were faster (I have sent a patch parallelly with a detailed changelog).
> Do me a favour next time, when I am reporting issues, just trust me.
I did trust you. I spent time trying to reproduce the same thing. Like I 
said, it syncs for me just fine.

What I said was that I couldn't reproduce the same outcome as you were. 
I hardly ignored what you were saying.

And I'm not sure why your comments are relevant. The sync has nothing to 
do with the patch you submitted. Your patch only has relevance at 
initial "git clone" time, not when we sync. This is the sync code. 
Although llvm-clean is run, llvm-fetch isn't, since the stamp file has 
already been created for that step.

##############################################################################
llvmsync = $(call banner,Updating ${1}...) ; \
     $(call unpatch,${2}) ; \
     [ ! -d ${2} ] || if [ -n "${4}" ] ; then \
         $(call banner,Syncing commit-ish ${1}...) ; \
         $(call gitcheckout,${2},${3},${4}) ; \
     else \
         $(call gitpull,${2},${3}) ; \
     fi

##############################################################################
llvm-sync: llvm-clean
     @$(call check_llvmlinux_commit,${CONFIG})
     @$(call llvmsync,LLVM,${LLVMDIR},${LLVM_BRANCH},${LLVM_COMMIT})
     @$(call llvmsync,unpatched 
LLVM,${LLVMDIR2},${LLVM_BRANCH},${LLVM_COMMIT})


The bug you found is important, but irrelevant to the behaviour you 
reported.

> When I am unsure or don't know I am honest enough to admit it.
Sounds good.

Behan

-- 
Behan Webster
behanw at converseincode.com



More information about the LLVMLinux mailing list