[llvmlinux] Multiple storage class error

[Renato Golin]

On 17 November 2013 15:45, Behan Webster <behanw at converseincode.com> wrote:

> So, in that case, you could have an #elif __gcc with the GCC case and an
> #else with an error message "Compiler doesnt support builtin_whatever".
> Once the builtin is accepted on both compilers, you can merge them all, but
> still leave the #error, so that new compilers will have a very nice message
> telling them to implement the builtin.
>
> Hm. I see what you're suggesting. I suppose that would work.
>

I believe all compilers that claim GCC compatibility, including older
versions of GCC, will set the same flags, so #ifs and #ifdefs should work
with them. If the kernel is currently compiled with the "alternatives", it
should just continue to do so.

The problem arises if there are other compilers building the kernel that
don't define __gcc etc BUT implement the necessary GCC-extensions
(proprietary ones, like icc). My guess is that there aren't that many
proprietary compilers that try to compile the kernel, but that could be an
issue upstream.

All that said, this is just bad practice, not broken code. So don't sweat
too much about it. ;)

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/llvmlinux/attachments/20131117/894015ba/attachment.html>