[llvmlinux] Patch to export build variables

Tinti viniciustinti at gmail.com
Thu Sep 26 11:49:55 UTC 2013


Understood. I will review it and send it back :)


On Thu, Sep 26, 2013 at 8:46 AM, Behan Webster <behanw at converseincode.com>wrote:

> On 09/26/13 07:34, Tinti wrote:
>
>> Hi,
>>
>> Can I merge this patch? I do it quite often to do my tests and I think it
>> might be useful for some one.
>>
>>  Patches direct in email, not as attachments please. It makes patch
> review 10x faster, and means people can comment directly on your code.
> git-send-email is the best tool for the job.
>
> However, having said that, I see what you're trying to do.
>
> - I'm not happy with the name of "export". Maybe change it to
> "export-build-parameters"? It's long, but that's what tab completion is
> for. ;)
> - You don't need to do the seperate patch step, the configure will make
> sure the kernel is patched.
> - You should be doing a "cd ${KERNEL_BUILD}" and "cd ${KERNELGCC_BUILD}"
> in order to not break things for people using the tmpfs-build system (which
> builds the kernel out-of-tree on a tmpfs in order to speed compiles, and
> not wear out SSD drives).
> - It also might be worth adding the ARCH and CROSS_COMPILE directives to
> the kernel make command line. We do it as an env variable in the LLVMLinux
> build system for convenience. But when you do it at the command line its
> better form to do it as a part of the make command (makes those settings
> explicit). Or at least that's my opinion. :)
>
> Behan
>
> --
> Behan Webster
> behanw at converseincode.com
>
> ______________________________**_________________
> LLVMLinux mailing list
> LLVMLinux at lists.**linuxfoundation.org<LLVMLinux at lists.linuxfoundation.org>
> https://lists.linuxfoundation.**org/mailman/listinfo/llvmlinux<https://lists.linuxfoundation.org/mailman/listinfo/llvmlinux>
>



-- 
Simplicity is the ultimate sophistication
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/llvmlinux/attachments/20130926/c2cb1f9f/attachment-0001.html>


More information about the LLVMLinux mailing list