[llvmlinux] Added patch for detection of compilers that support unwind for ARM. Now clang is detected.

Jan-Simon Möller jsmoeller at linuxfoundation.org
Wed Jan 29 17:14:18 UTC 2014


Am Mittwoch, 29. Januar 2014, 16:20:32 schrieb David Woodhouse:
> And that's absolutely sane. But I think it's useful to keep tabs on what
> we do have — where we have patches which are sane for upstream they
> should be pushed that way as rapidly as possible, and where we have
> workarounds for LLVM they should clearly identify the PR# that they
> address. Looking through the patches we have at the moment, it's
> sometimes hard to tell what's being fixed, and why.
> 
> For example,
> /arch/i586/patches/9004_fix_for_edx_register_on_64_bit_as_suggested_by_hpa.p
> atch gives me *no* context about what the problem is or where to find the
> existing discussion about it.

You're right. Not all patches have the needed doc or references in place.

> 
> > > There's definitely merit in sending the simple and straightforward
> > > *fixes* upstream under separate cover, as quickly as they're generated.
> > 
> > Then we should start doing so. Thanks for the suggestion. Can I ask you
> > to be a reviewer for such a repo?
> 
> Yeah, absolutely. If you want to let me have simple patches with a clear
> commit comment I can certainly shepherd those upstream.

Cool, tnx. 

-- 

Sincerely yours,

Jan-Simon Möller

jsmoeller at linuxfoundation.org



More information about the LLVMLinux mailing list