[Lsb-messages] /var/www/bzr/lsb/devel/dbadmin r277: improve consistency checker wordings (some problems with last batch)
Mats Wichmann
mats at linuxfoundation.org
Fri Feb 22 17:10:42 UTC 2013
------------------------------------------------------------
revno: 277
committer: Mats Wichmann <mats at linuxfoundation.org>
branch nick: dbadmin
timestamp: Fri 2013-02-22 10:10:42 -0700
message:
improve consistency checker wordings (some problems with last batch)
modified:
consistency/queries.php
-------------- next part --------------
=== modified file 'consistency/queries.php'
--- a/consistency/queries.php 2013-02-22 16:44:02 +0000
+++ b/consistency/queries.php 2013-02-22 17:10:42 +0000
@@ -70,7 +70,7 @@
$numrows = count($res);
if( $title ) {
print("<h1>$title ($numrows ".entry($numrows).")</h1>\n");
- print "<p/>$desc\n";
+ print "<h3>$desc</h3>\n";
}
else {
print "<h2>$desc ($numrows ".entry($numrows).")</h2>\n";
@@ -892,8 +892,8 @@
$res = Query($select);
$numrows = count($res);
$numFields = pdo_num_fields($res);
- print("<h1>Derived Types without Base Type Inforrmation ($numrows ".entry($numrows).")</h1>");
- print("<h3>Derived types without base type infromtaion (ATbasetype is NULL or zero)</h3>");
+ print("<h1>Derived Types without Base Type Information ($numrows ".entry($numrows).")</h1>");
+ print("<h3>Derived types without base type information (ATbasetype is NULL or zero)</h3>");
if ($numrows) {
print("<table class='wikitable'>\n");
print_table_header('Tid', 'Tname', 'Ttype');
@@ -1046,7 +1046,7 @@
.'DELETE FROM CompLDpath WHERE CLDcid={$1};';
print("<h1>Component Aliases with Associated Entities ($numrows ".entry($numrows).")</h1>");
- print("<h3>Components with Calias > 0 should not have any assotiated items</h3>");
+ print("<h3>Components with Calias > 0 should not have any associated items</h3>");
if ($numrows) {
$numrows = count($res);
$numFields = pdo_num_fields($res);
@@ -1252,7 +1252,7 @@
$res = Query($select);
$numrows = count($res);
print("<h1>Typedef Basetype Architecture Mismatch</h1>");
- print("<h3>Typedef basetype architecture mismatch - Typedefs on complex types are included for some Architectures, while their Bases have no ArchType Data for those Arches. This means that devchk will not test such Types.</h3>");
+ print("<h3>Typedefs on complex Types are included for some architectures, while their basetypes have no archtype data for them. This means that devchk will not test such Types.</h3>");
if ($numrows) {
print("<table class='wikitable'>\n");
print_table_header('Tid', 'Tname', 'ATbasetype', 'ATaid');
@@ -1337,7 +1337,7 @@
$numrows = count($res);
print("<h1>Biarch Components</h1>");
print("<h3>The following components contain binary elements for more then one architecture. "
- ."They should be divided on several records, one per architecture.</h3>");
+ ."They should be divided into several records, one per architecture.</h3>");
if ($numrows) {
print("<table class='wikitable'>\n");
print_table_header('Cid');
@@ -1399,6 +1399,8 @@
AND ISrefspecurl IS NULL";
$res = Query($select);
$numrows = count($res);
+ print("<h1>Interface Missing Reference URL ($numrows ".entry($numrows).")</h1>");
+ print("<h3>The following interfaces are marked as having a referenced spec in addition to a main spec, but have no URL to the referenced spec</h3>");
if ($numrows) {
print("<table class='wikitable'>\n");
@@ -1507,7 +1509,9 @@
$res=Query($query);
$numrows = count($res);
print("<h1>$title ($numrows ".entry($numrows).")</h1>\n");
- print("<h3>$desc</h3>\n");
+ if( $desc ) {
+ print("<h3>$desc</h3>\n");
+ }
if ($numrows) {
print("<table class='wikitable'>\n");
print_table_header('AIint', 'AIarch', 'AIdeprecatedsince');
@@ -1530,7 +1534,9 @@
$res=Query($query);
$numrows = count($res);
print("<h1>$title ($numrows ".entry($numrows).")</h1>\n");
- print("<h3>$desc</h3>\n");
+ if( $desc ) {
+ print("<h3>$desc</h3>\n");
+ }
if ($numrows) {
print("<table class='wikitable'>\n");
print_table_header('SMid', 'SMdeprecatedsince');
@@ -1552,7 +1558,9 @@
$res=Query($query);
$numrows = count($res);
print("<h1>$title ($numrows ".entry($numrows).")</h1>\n");
- print("<h3>$desc</h3>\n");
+ if( $desc ) {
+ print("<h3>$desc</h3>\n");
+ }
if ($numrows) {
print("<table class='wikitable'>\n");
print_table_header('Lid', 'Ldeprecatedsince');
@@ -1574,7 +1582,9 @@
$res=Query($query);
$numrows = count($res);
print("<h1>$title ($numrows ".entry($numrows).")</h1>\n");
- print("<h3>$desc</h3>\n");
+ if( $desc ) {
+ print("<h3>$desc</h3>\n");
+ }
if ($numrows) {
print("<table class='wikitable'>\n");
print_table_header('Pint', 'Ppos', 'Tid');
@@ -1597,7 +1607,9 @@
$res=Query($query);
$numrows = count($res);
print("<h1>$title ($numrows ".entry($numrows).")</h1>\n");
- print("<h3>$desc</h3>\n");
+ if( $desc ) {
+ print("<h3>$desc</h3>\n");
+ }
if ($numrows) {
print("<table class='wikitable'>\n");
print_table_header('Iid', 'AIreturn');
@@ -1619,7 +1631,9 @@
$res=Query($query);
$numrows = count($res);
print("<h1>$title ($numrows ".entry($numrows).")</h1>\n");
- print("<h3>$desc</h3>\n");
+ if( $desc ) {
+ print("<h3>$desc</h3>\n");
+ }
if ($numrows) {
print("<table class='wikitable'>\n");
print_table_header('Iname', 'Ilibrary');
@@ -1642,7 +1656,9 @@
$res=Query($query);
$numrows = count($res);
print("<h1>$title ($numrows ".entry($numrows).")</h1>\n");
- print("<h3>$desc</h3>\n");
+ if( $desc ) {
+ print("<h3>$desc</h3>\n");
+ }
if ($numrows) {
print("<table class='wikitable'>\n");
print_table_header('Sname');
@@ -1663,7 +1679,9 @@
$res=Query($query);
$numrows = count($res);
print("<h1>$title ($numrows ".entry($numrows).")</h1>\n");
- print("<h3>$desc</h3>\n");
+ if( $desc ) {
+ print("<h3>$desc</h3>\n");
+ }
if ($numrows) {
$fix_tmpl = 'UPDATE IntStd SET ISsid=159 WHERE ISiid={$1} AND ISappearedin != \'\' AND ISwithdrawnin IS NULL';
$numFields = pdo_num_fields($res);
@@ -1699,7 +1717,9 @@
$numFields = pdo_num_fields($res);
print("<h1>$title ($numrows ".entry($numrows).")</h1>\n");
- print("<h3>$desc</h3>\n");
+ if( $desc ) {
+ print("<h3>$desc</h3>\n");
+ }
if ($numrows) {
print("<table class='wikitable'>\n");
print_table_header('Iid', 'Iname', 'Ifkind', 'AIreturn', 'Possible Fix');
@@ -1730,7 +1750,9 @@
$res=Query($query);
$numrows = count($res);
print("<h1>$title ($numrows ".entry($numrows).")</h1>\n");
- print("<h3>$desc</h3>\n");
+ if( $desc ) {
+ print("<h3>$desc</h3>\n");
+ }
if ($numrows) {
print("<table class='wikitable'>\n");
print_table_header('Sname');
@@ -1751,7 +1773,9 @@
$res=Query($query);
$numrows = count($res);
print("<h1>$title ($numrows ".entry($numrows).")</h1>\n");
- print("<h3>$desc</h3>\n");
+ if( $desc ) {
+ print("<h3>$desc</h3>\n");
+ }
if ($numrows) {
print("<table class='wikitable'>\n");
print_table_header('Tid', 'Tname', 'Ttype');
@@ -1774,7 +1798,9 @@
$res=Query($query);
$numrows = count($res);
print("<h1>$title ($numrows ".entry($numrows).")</h1>\n");
- print("<h3>$desc</h3>\n");
+ if( $desc ) {
+ print("<h3>$desc</h3>\n");
+ }
if ($numrows) {
$numFields = pdo_num_fields($res);
$fix_tmpl = 'UPDATE Interface SET Iheader=0, Idocumented=\'Yes\', Itestable=\'No\' WHERE Iid={$1}';
@@ -1813,7 +1839,9 @@
$fix_tmpl='UPDATE Interface SET Idocumented=\'Yes\' WHERE Iid={$1}';
print("<h1>$title ($numrows ".entry($numrows).")</h1>\n");
- print("<h3>$desc</h3>\n");
+ if( $desc ) {
+ print("<h3>$desc</h3>\n");
+ }
if ($numrows) {
print("<table class='wikitable'>\n");
print_table_header('Iid', 'Iname', 'ISurl', 'Possible Fix');
@@ -2082,7 +2110,7 @@
* Display fixes as text
*/
print("<h1>".$_POST['Title']."</h1>\n");
- print("<h3>The following fixes will probably fix the issues</h3>\n");
+ print("<h3>The following changes will probably fix the issues</h3>\n");
$fixes = $_POST['display_fixes'];
$queries = explode(';', $fixes);
@@ -2448,7 +2476,7 @@
case "consist-mis-doccmd" :
$title = "Included Commands without Documentation";
$desc = "The following commands are in the standard, but marked as undocumented. ";
- $desc.= "This can be considered outstanding issues.";
+ $desc.= "These can be considered outstanding issues.";
$select = "SELECT Cid, Cname FROM Command
LEFT JOIN SModCmd ON SMCcid=Cid
WHERE Cdocumented !='Yes'
@@ -2541,7 +2569,7 @@
case "consist-mis-library" :
$title = "Included Interfaces with Empty 'Ilibrary' Field";
$desc = "The following interfaces have empty 'Ilibrary' field. ";
- $desc.= "This can be considered outstanding issues.";
+ $desc.= "These can be considered outstanding issues.";
$select = "SELECT Iid, Iname, Iunmangled, Ilibrary, Sname, COUNT(DISTINCT Sid) AS StdCnt, Surl FROM Interface
LEFT JOIN ArchInt ON AIint=Iid
LEFT JOIN IntStd ON ISiid=Iid
@@ -2557,7 +2585,7 @@
case "LSBcmd-mis-doc" :
$title = "LSB Commands not Documented";
$desc = "The following commands are specified in the LSB, but marked as undocumented ";
- $desc.= "This can be considered outstanding issues.";
+ $desc.= "These can be considered outstanding issues.";
$select = "SELECT Cid, Cname FROM Command
LEFT JOIN CmdStd ON CScid=Cid
WHERE CSsid=10
@@ -2754,8 +2782,6 @@
output_int_lib_app();
break;
case "int-missing-refurl":
- $title = "Interface Missing Reference URL";
- $desc = "The following interfaces are marked as having a referenced spec in addition to a main spec, but have no URL to the referenced spec";
output_missing_refurls();
break;
case "incorrect-cinumvtab" :
More information about the lsb-messages
mailing list