[Openais] event service channel fix

Mark Haverkamp markh at osdl.org
Thu Oct 14 16:02:56 PDT 2004


On Thu, 2004-10-14 at 15:21 -0700, Steven Dake wrote:
> Mark
> 
> I think the patch looks pretty good
> 
> I have a question further down in the patch if you could take a look. 
> Something looks a little suspect.
> 

[...]

> > @@ -2675,11 +2681,12 @@
> >  	 */
> >  	if (!eci) {
> >  		if (evtpkt->led_retention_time) {
> > -			eci = create_channel(&evtpkt->led_chan_name);
> > +			// eci = create_channel(&evtpkt->led_chan_name);
> 
> Is eci already defined above here?  If so, is the commented out code
> needed?

It used to be needed before I added the code to track the open channels
between the nodes.  This should really not happen anymore because the
channel data structure should either be created by an open command or
when open channel information is communicated at a config change.

I didn't quite clean these sections up properly.  I've included an
update patch to take care of these sections.

Thanks,
Mark.

-- 
Mark Haverkamp <markh at osdl.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: evt.patch
Type: text/x-patch
Size: 12069 bytes
Desc: 
Url : http://lists.linux-foundation.org/pipermail/openais/attachments/20041014/6ab76fb3/evt-0001.bin


More information about the Openais mailing list