[Openais] event service channel fix

Steven Dake sdake at mvista.com
Thu Oct 14 16:46:59 PDT 2004


Mark

THe patch looks good apply when ready

One minor note.. With the upcoming update to the configuration and
logging system, there is no longer a need to place (EVT) in the
log_printf call.  It will be done automatically for you with no further
changes to the code other then a minor change at the head of evt.  This
has been done in defect-145-2.patch already.

Can you remove all that extra (EVT) in the log_printfs as a seperate
patch after defect-145-2 goes in to the tree?

Thanks
-steve

On Thu, 2004-10-14 at 16:02, Mark Haverkamp wrote:
> On Thu, 2004-10-14 at 15:21 -0700, Steven Dake wrote:
> > Mark
> > 
> > I think the patch looks pretty good
> > 
> > I have a question further down in the patch if you could take a look. 
> > Something looks a little suspect.
> > 
> 
> [...]
> 
> > > @@ -2675,11 +2681,12 @@
> > >  	 */
> > >  	if (!eci) {
> > >  		if (evtpkt->led_retention_time) {
> > > -			eci = create_channel(&evtpkt->led_chan_name);
> > > +			// eci = create_channel(&evtpkt->led_chan_name);
> > 
> > Is eci already defined above here?  If so, is the commented out code
> > needed?
> 
> It used to be needed before I added the code to track the open channels
> between the nodes.  This should really not happen anymore because the
> channel data structure should either be created by an open command or
> when open channel information is communicated at a config change.
> 
> I didn't quite clean these sections up properly.  I've included an
> update patch to take care of these sections.
> 
> Thanks,
> Mark.




More information about the Openais mailing list