[Openais] Logging patch.

Mark Haverkamp markh at osdl.org
Thu Oct 28 10:41:14 PDT 2004


On Thu, 2004-10-28 at 10:39 -0700, Mark Haverkamp wrote:
> On Thu, 2004-10-28 at 10:28 -0700, Steven Dake wrote:
> > Daniel
> > 
> > Separate functions for each log level seem like a good idea to me.  I'm
> > not sure how the stack is different for the changes you have made (was
> > it va_start/va_end that was causing the problem?), but the changes look
> > fine to me.
> > 
> > Could you fix a few things though?
> > 
> > 1. ais_error should be ais_log_error.  Same for the other functions.
> > 
> > 2. There must be a ais_log_security and ais_log_debug.
> > 
> > 3. LOG_SERVICE should remain undefined and should cause a compile error
> > if it is undefined.  This happens now automatically but it could be
> > cleaner with something like this in the print.h header file:
> 
> Speaking of which, print.c gets a LOG_SERIVCE undefined in a clm
> function (printSaClmClusterNodeT) if DEBUG is defined.

I should have said, in the current bk view.


-- 
Mark Haverkamp <markh at osdl.org>




More information about the Openais mailing list