[Openais] [PATCH] Use objdb

Steven Dake scd at broked.org
Mon Apr 3 10:38:03 PDT 2006


On Mon, 2006-04-03 at 03:59, Patrick Caulfield wrote:
> Steven Dake wrote:
> > Patrick
> > 
> > Good work exactly what I had in mind.
> > 
> > Few comments which I'd like resolved before commit
> > 
> > I really dislike the name "conffile" could we use "aisparser" instead?
> 
> no problem.
> 

cool

> > There seem to be a lot of
> > -
> > +
> > What are these in the patch for?
> 

ok this is fine I am not opposed to cleaning up the code wherever there
are problems :)

> They are where my emacs macro has removed trailing spaces at the end of a
> line. I'll try to tidy them up...but I /hate/ trailing spaces :)
> 
> > If any "service" parameter is specified, none of the default services
> > will link with your changes.  What I would prefer is that all default
> > services link in all cases, and if the user wants a newer version of a
> > default service, they can specify the service tags in their
> > configuration file and it will overwrite the key/value pair.
> >
> > In the case the default configuration parser is overridden, I would also
> > like the default services to link.
> > 
> 
> 
> I was trying to get a system where the user could remove service that were not
> needed. How about a "defaultservices: " option which defaults to "yes"? that
> way the user could override the default service list if necessary or simply
> update versions if that's what is wanted ?

This works for me.  As long as the user wants to turn off default
services, they should be able to.  From a support standpoint, I don't
want services disabled by default though, because it might make for some
confusion when trying to configure openais.

I'd still like in the case that defaultservices is yes that service
version numbers can be overridden.  I'll work that out as a separate
patch though.

Regards
-steve




More information about the Openais mailing list