[Openais] [PATCH] Use objdb
Hans Feldt
Hans.Feldt at ericsson.com
Mon Apr 10 02:07:23 PDT 2006
A couple of things:
1. The default user/group config is not working. A line with:
objdb->object_find_reset (OBJECT_PARENT_HANDLE);
before the aisexec section fixes the problem.
2. BUILD_DYNAMIC=0 does not work. amfconfig.c missing in build.
3. Now when we have this nicer way of configuring user/group, why not
revert, take out my patch where it was configured at compile time? We
only need one way of doing this and this is the best way.
4. I think the location of openais.conf should be configurable at the
aisexec command line and not at compile time. Of course defaults to
/etc/ais.
5. I don't understand why the "amf-mode-enabled" needs to be there. If
some Openais user does not want the AMF service, delete
service_amf.lcrso and its not loaded! Maybe some other Openais user does
not want service X, should there be a x-mode-enabled then? If needed
(due to static linked services?), the logic should be inverted to
amf-mode-disabled: yes/no
6. The location of groups.conf should be configurable in openais.conf.
Why? groups.conf is probably cluster specific and openais.conf is node
specific and probably stored in different directories.
I have reworked the daemon patch that Bjorn Andersson sent to the
mailing list (it got lost?), I could include the stuff (3-6) in there if
you like?
Regards,
Hans
Steven Dake wrote:
> I like the first suggestion
>
> regards
> -steve
>
> On Fri, 2006-04-07 at 00:48, Patrick Caulfield wrote:
>
>>Steven Dake wrote:
>>
>>>Patrick
>>>
>>>A bug was introduced in this patch:
>>>
>>>When I use the following logoutput lines
>>> logoutput: stderr
>>> logoutput: syslog
>>> logoutput: file
>>>
>>>I don't get stderr output any longer
>>>
>>>Could you look into it? I think logoutput may have to be treated like
>>>an object (meaning changes to the config file and man pages) instead of
>>>a key because there can only be one key per object, but there can be
>>>multiple objects per object.
>>>
>>
>>How about changing it (it will have to be changed anyway!) to something like
>>
>>logging {
>> to_stderr: yes
>> to_syslog: yes
>> to_file: yes
>>}
>>
>>The object syntax is a bit over the top for single-key items I think - it
>>would end up like:
>>
>>logging {
>> logoutput {
>> stderr: yes
>> }
>> logoutput {
>> syslog: yes
>> }
>> logoutput {
>> file: yes
>> }
>>}
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Openais mailing list
> Openais at lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/openais
More information about the Openais
mailing list