[Openais] STATICLIBS install logic error in 0.82 and trunk

Steven Dake sdake at redhat.com
Thu Sep 27 02:22:57 PDT 2007


Mark

A variation on this patch has been applied to the trunk.

Thanks for pointing this out

Regards
-steve
On Sat, 2007-09-22 at 13:58 -0500, Mark Reidenbach wrote:
> Starting in 0.82 and trunk, the logic for installing static libs was 
> inverted.  Previous versions used
>     ifneq "NO" "$(STATICLIBS)"
> but this was changed to
>     if [ "xNO" = "x$(STATICLIBS)" ]; then
> which installs the static libs when STATICLIBS = NO and doesn't if it's 
> set to YES.
> 
> 
> This simple patch corrects the logic:
> --- Makefile.1454       2007-09-22 13:51:01.000000000 -0500
> +++ Makefile    2007-09-22 13:51:32.000000000 -0500
> @@ -103,7 +103,7 @@
>             $(CP) -a lib/lib$$aLib.so $(DESTDIR)$(LIBDIR);              \
>             $(CP) -a lib/lib$$aLib.so.2 $(DESTDIR)$(LIBDIR);            \
>             install -m 755 lib/lib$$aLib.so.2.* $(DESTDIR)$(LIBDIR);    \
> -           if [ "xNO" = "x$(STATICLIBS)" ]; then                       \
> +           if [ "xNO" != "x$(STATICLIBS)" ]; then                      \
>                 install -m 755 lib/lib$$aLib.a $(DESTDIR)$(LIBDIR);     \
>                 if [ ${OPENAIS_COMPAT} = "DARWIN" ]; then               \
>                     ranlib $(DESTDIR)$(LIBDIR)/lib$$aLib.a;             \
> 
> 
> 
> 
> 
> _______________________________________________
> Openais mailing list
> Openais at lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/openais



More information about the Openais mailing list