[Openais] [PATCH]: openais/trunk: Only send response/callback when unlocking pending locks

Jan Friesse jfriesse at redhat.com
Wed Jun 10 07:20:51 PDT 2009


Ryan,
this patch breaks SAF Test SaLckLockGrantCallbackT/10.c, and there is
no close before unlock. I made a patch, but I'm really not sure about
correctness.

Regards,
  Honza

Ryan O'Hara wrote:
> When unlocking a pending lock request, we must send a response (or
> callback) to the library indicating an error occured. This patch
> simply adds a check that the lock is pending before we send the
> response.
> 
> Without this fix, callbacks are sent when they are not needed. For
> example, if we close a resource while holding locks we will hit this
> code (in lck_unlock) that will incorrectly send callbacks to the
> library.
> 
> Ryan
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Openais mailing list
> Openais at lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/openais

-------------- next part --------------
A non-text attachment was scrubbed...
Name: lck_send_callback.patch
Type: text/x-patch
Size: 504 bytes
Desc: not available
Url : http://lists.linux-foundation.org/pipermail/openais/attachments/20090610/e0f2f502/attachment.bin 


More information about the Openais mailing list