[Openais] [PATCH 7/9] logsys: port to new packed rec_ident version

Fabio M. Di Nitto fdinitto at redhat.com
Wed Jun 17 14:30:59 PDT 2009


On Wed, 2009-06-17 at 14:04 -0700, Steven Dake wrote:
> On Wed, 2009-06-17 at 22:56 +0200, Fabio M. Di Nitto wrote:
> > On Wed, 2009-06-17 at 08:55 -0700, Steven Dake wrote:
> > > looks good
> > > 
> > > Did you try benchmarks prior/before?   Curious if faster/slower.
> > 
> > Yes I did and the packing/unpacking is slower but barely noticeable.
> > 
> > before it was approx: 6700000 ops/sec
> > after it was approx:  6680000 ops/sec
> 
> I'm a bit surprised by this,

Not sure what to say... I was expecting a lot worst but..

>  but I think the gain in internal use should
> be worth the minimal loss in performance.

...the benchmark is done at _logsys_log_rec level that does only two
unpacking operations in the whole code (and not in any loop) and one
buffer/strlen operation less.

So after all the log_rec isn't affected that deeply by those code
changes.

Fabio



More information about the Openais mailing list