[Openais] [PATCH corosync] totemsrp: remove unnecessary cast to avoid "make syntax-check" failure

Jim Meyering jim at meyering.net
Sun Jun 21 09:59:55 PDT 2009


Hi,

alloca is always declared to return "void *", these days.
Without it', and with my pending gnulib patch, "make syntax-check"
would fail, complaining about the unneeded cast.

While on the subject, it's best to avoid alloca altogether,
unless you can guarantee that the required buffer length is
always < 1kB or 4kB, depending on how much you care about
embedded systems and/or stack-limited systems.
However, using malloc might be more invasive, due to the
need to handle failure.



More information about the Openais mailing list