[Openais] [PATCH openais 8/9] don't include <signal.h> when assert is not used

Steven Dake sdake at redhat.com
Sun Jun 21 12:42:46 PDT 2009


patch looks good

On Sun, 2009-06-21 at 20:42 +0200, Jim Meyering wrote:
> From: Jim Meyering <meyering at redhat.com>
> 
> * lib/amf.c:
> * services/amf.c:
> * services/ckpt.c:
> * services/clm.c:
> * services/lck.c:
> * services/msg.c:
> * services/openaisserviceenable.c:
> * services/tmr.c:
> * test/testlck2.c:
> * test/testmsg2.c:
> * test/testmsg3.c:
> * test/testtmr.c:
> ---
>  lib/amf.c                       |    1 -
>  services/amf.c                  |    1 -
>  services/ckpt.c                 |    1 -
>  services/clm.c                  |    3 +--
>  services/lck.c                  |    1 -
>  services/msg.c                  |    1 -
>  services/openaisserviceenable.c |    1 -
>  services/tmr.c                  |    3 +--
>  test/testlck2.c                 |    1 -
>  test/testmsg2.c                 |    1 -
>  test/testmsg3.c                 |    1 -
>  test/testtmr.c                  |    1 -
>  12 files changed, 2 insertions(+), 14 deletions(-)
> 
> diff --git a/lib/amf.c b/lib/amf.c
> index e7e8ffb..6ac1353 100644
> --- a/lib/amf.c
> +++ b/lib/amf.c
> @@ -40,7 +40,6 @@
>  #include <stdlib.h>
>  #include <unistd.h>
>  #include <errno.h>
> -#include <signal.h>
>  #include <pthread.h>
>  #include <sys/types.h>
>  #include <sys/socket.h>
> diff --git a/services/amf.c b/services/amf.c
> index 3b0896a..fd71cfc 100644
> --- a/services/amf.c
> +++ b/services/amf.c
> @@ -135,7 +135,6 @@
>  #include <stdlib.h>
>  #include <stdio.h>
>  #include <errno.h>
> -#include <signal.h>
>  #include <string.h>
>  #include <pthread.h>
>  #include <assert.h>
> diff --git a/services/ckpt.c b/services/ckpt.c
> index 5a33aa5..c9fda14 100644
> --- a/services/ckpt.c
> +++ b/services/ckpt.c
> @@ -46,7 +46,6 @@
>  #include <stdlib.h>
>  #include <stdio.h>
>  #include <errno.h>
> -#include <signal.h>
>  #include <arpa/inet.h>
>  #include <inttypes.h>
> 
> diff --git a/services/clm.c b/services/clm.c
> index 0473b60..c367739 100644
> --- a/services/clm.c
> +++ b/services/clm.c
> @@ -1,6 +1,6 @@
>  /*
>   * Copyright (c) 2002-2006 MontaVista Software, Inc.
> - * Copyright (c) 2006-2007 Red Hat, Inc.
> + * Copyright (c) 2006-2007, 2009 Red Hat, Inc.
>   * Copyright (C) 2006 Sun Microsystems, Inc.
>   *
>   * All rights reserved.
> @@ -53,7 +53,6 @@
>  #include <stdlib.h>
>  #include <stdio.h>
>  #include <errno.h>
> -#include <signal.h>
>  #include <time.h>
>  #include <unistd.h>
>  #include <netinet/in.h>
> diff --git a/services/lck.c b/services/lck.c
> index 75d350f..8fcc57d 100644
> --- a/services/lck.c
> +++ b/services/lck.c
> @@ -46,7 +46,6 @@
>  #include <stdlib.h>
>  #include <stdio.h>
>  #include <errno.h>
> -#include <signal.h>
>  #include <time.h>
>  #include <arpa/inet.h>
> 
> diff --git a/services/msg.c b/services/msg.c
> index c0cf6dd..80b6a48 100644
> --- a/services/msg.c
> +++ b/services/msg.c
> @@ -46,7 +46,6 @@
>  #include <stdlib.h>
>  #include <stdio.h>
>  #include <errno.h>
> -#include <signal.h>
>  #include <time.h>
>  #include <arpa/inet.h>
> 
> diff --git a/services/openaisserviceenable.c b/services/openaisserviceenable.c
> index 228a7f6..7733e76 100644
> --- a/services/openaisserviceenable.c
> +++ b/services/openaisserviceenable.c
> @@ -45,7 +45,6 @@
>  #include <stdlib.h>
>  #include <stdio.h>
>  #include <errno.h>
> -#include <signal.h>
>  #include <string.h>
> 
>  #include <corosync/engine/objdb.h>
> diff --git a/services/tmr.c b/services/tmr.c
> index 3b5a5ec..03caf48 100644
> --- a/services/tmr.c
> +++ b/services/tmr.c
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2008 Red Hat, Inc.
> + * Copyright (c) 2008, 2009 Red Hat, Inc.
>   *
>   * All rights reserved.
>   *
> @@ -45,7 +45,6 @@
>  #include <stdlib.h>
>  #include <stdio.h>
>  #include <errno.h>
> -#include <signal.h>
>  #include <time.h>
>  #include <arpa/inet.h>
> 
> diff --git a/test/testlck2.c b/test/testlck2.c
> index 0388979..918b325 100644
> --- a/test/testlck2.c
> +++ b/test/testlck2.c
> @@ -37,7 +37,6 @@
>  #include <stdlib.h>
>  #include <string.h>
>  #include <errno.h>
> -#include <signal.h>
>  #include <unistd.h>
>  #include <pthread.h>
>  #include <sys/types.h>
> diff --git a/test/testmsg2.c b/test/testmsg2.c
> index e796972..25cfa43 100644
> --- a/test/testmsg2.c
> +++ b/test/testmsg2.c
> @@ -37,7 +37,6 @@
>  #include <stdlib.h>
>  #include <string.h>
>  #include <errno.h>
> -#include <signal.h>
>  #include <unistd.h>
>  #include <sys/types.h>
>  #include <sys/socket.h>
> diff --git a/test/testmsg3.c b/test/testmsg3.c
> index fc09d05..8d0ed42 100644
> --- a/test/testmsg3.c
> +++ b/test/testmsg3.c
> @@ -37,7 +37,6 @@
>  #include <stdlib.h>
>  #include <string.h>
>  #include <errno.h>
> -#include <signal.h>
>  #include <unistd.h>
>  #include <sys/types.h>
>  #include <sys/socket.h>
> diff --git a/test/testtmr.c b/test/testtmr.c
> index 1a57d94..15ed530 100644
> --- a/test/testtmr.c
> +++ b/test/testtmr.c
> @@ -37,7 +37,6 @@
>  #include <stdlib.h>
>  #include <string.h>
>  #include <errno.h>
> -#include <signal.h>
>  #include <unistd.h>
>  #include <pthread.h>
>  #include <inttypes.h>



More information about the Openais mailing list