[Openais] [PATCH] corosync/trunk: fix/improve rpm package versioning

Fabio M. Di Nitto fdinitto at redhat.com
Fri Jun 26 00:00:45 PDT 2009


Hi,

extra integration testing did show a series of issues with rpm
autogenerated version system.

the following patch addresses them.

Issues details:

1) a version trunk-1.r1234 is < 0.XX release breaking upgrade paths from
release X to trunk to release X+1.

2) alpha tag can contain M or S or MS. Eg. r1234M is < r1234 breaking
rpm upgrade path.

Solution:

after investigation, the only natural and clean solution is to use the
"svn previous tag" version number + a clean alpha tag.

In order to address #1 we need to introduce an helper script
(svn-helper.sh) to determine the last known tag in svn.
the script will return "unknown" if it is not possible to determine
those information or the tools to determine those information are not
available.

Makefile.am defines an RPMVERSION detected by svn-helper.sh. The value
can be easily overridden at make srpm/rpm invokation time.
For eg:

make srpm RPMVERSION=x.y.z

this is useful if svn-helper.sh can't detect the information and we need
to create a specific rpm version.

In order to address #2 we simply apply a regexp to filter out unrequired
data.

Fabio
-------------- next part --------------
A non-text attachment was scrubbed...
Name: improve_rpm.diff
Type: text/x-patch
Size: 1985 bytes
Desc: not available
Url : http://lists.linux-foundation.org/pipermail/openais/attachments/20090626/11d36bc2/attachment.bin 


More information about the Openais mailing list