[Openais] [PATCH 0/8] fixes for the new COVERITY scan

Angus Salkeld angus.salkeld at gmail.com
Sat Oct 24 15:55:26 PDT 2009


Here are the bugs.

Displaying 9 results.
Errors sorted by: Unsorted
CID 	Checker 	Status 	Owner 	Function 	File 	Run
View_18 	USE_AFTER_FREE 	BUG 	angus 	message_handler_req_exec_cpg_downlist 	services/cpg.c 	Run_2: corosync
View_17 	UNINIT 	BUG 	angus 	show_nodes 	tools/corosync-quorumtool.c 	Run_2: corosync
View_14 	RESOURCE_LEAK 	BUG 	angus 	zcb_alloc 	exec/coroipcs.c 	Run_2: corosync
View_13 	OVERRUN_STATIC 	BUG 	angus 	get_quorum_type 	tools/corosync-quorumtool.c 	Run_2: corosync
View_12 	OVERRUN_STATIC 	BUG 	angus 	log_printf_to_logs 	exec/logsys.c 	Run_2: corosync
View_12 	OVERRUN_STATIC 	BUG 	angus 	log_printf_to_logs 	exec/logsys.c 	Run_2: corosync
View_11 	DEADCODE 	BUG 	angus 	cpg_iteration_next 	lib/cpg.c 	Run_2: corosync
View_4 	DEADCODE 	BUG 	angus 	evs_dispatch 	lib/evs.c 	Run_2: corosync
View_3 	DEADCODE 	BUG 	angus 	cpg_dispatch 	lib/cpg.c 	Run_2: corosync

And here are the fixes.

Angus Salkeld (8):
   COVERITY 12: prevent overrun of output buffers.
   COVERITY 18: prevent deref after free.
   COVERITY 17: fix exit handling in show_votes()
   COVERITY 13: prevent buffer overrun.
   COVERITY 14: free zcb_mapped if memory_map() fails.
   COVERITY 11: remove dead code from cpg_iteration_next()
   COVERITY 3: remove dead code in cpg_dispatch()
   COVERITY 4: remove dead code in evs_dispatch()

  exec/coroipcs.c             |    1 +
  exec/logsys.c               |    4 ++--
  lib/cpg.c                   |   20 +++-----------------
  lib/evs.c                   |   18 ++----------------
  services/cpg.c              |    1 +
  tools/corosync-quorumtool.c |   15 +++++++++------
  6 files changed, 18 insertions(+), 41 deletions(-)


More information about the Openais mailing list