[PATCH 3/4] tun: Allow GSO using virtio_net_hdr
Rusty Russell
rusty at rustcorp.com.au
Thu Jul 24 16:54:18 PDT 2008
On Friday 25 July 2008 00:20:44 Herbert Xu wrote:
> On Thu, Jun 26, 2008 at 12:30:37AM +1000, Rusty Russell wrote:
> > Add a IFF_VNET_HDR flag. This uses the same ABI as virtio_net (ie.
> > prepending struct virtio_net_hdr to packets) to indicate GSO and checksum
> > information.
> >
> > Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
>
> I just noticed that we still allocate a linear skb even when GSO
> is enabled. Please fix this by allocating page frags where
> necessary. Otherwise GSO is only going to work before memory
> fragmentation sets in.
>
> IIRC I'd sent out a patch to the virt mailing list with code
> that did this.
>
> Thanks,
Hi Herbert,
Thanks for the reminder. I have this code in the virtio_net patches which
Linus failed to pull. Will just need to share it with the tun code (maybe a
skb_alloc_large() helper).
Cheers,
Rusty.
More information about the Virtualization
mailing list